Skip to content

Set skipArchival to true for getResultAsync #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

Set skipArchival to true for getResultAsync #990

merged 1 commit into from
Apr 11, 2025
+1 −0

Conversation

natemort
Copy link
Member

What changed?
Set skipArchival to true for the async flows. This is done in the sync flows.

Why?

  • When a request comes for workflow history, if the workflow doesn't exist and skipArchival is set to false then it immediately returns a BadRequestError. This results in there being no retries whatsoever (since BadRequestError isn't retried).
  • When requests go to the passive region they won't immediately observe the workflow existing (due to replication delay), so these requests will always fail.

How did you test it?

Potential risks

Release notes

Documentation Changes

@natemort natemort merged commit 255ecfd into cadence-workflow:master Apr 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidporter-id-au davidporter-id-au davidporter-id-au approved these changes

@Shaddoll Shaddoll Shaddoll approved these changes

@timl3136 timl3136 timl3136 approved these changes

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@abhishekj720 abhishekj720 Awaiting requested review from abhishekj720 abhishekj720 is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@natemort @davidporter-id-au @Shaddoll @timl3136